Support imgui v1.61 #73
Conversation
… into support_imgui_v1.60
Requires explicit call to create_context()
Requires end_frame() to be called before any subsequent calls to new_frame()
But the continuous integration tests on github are behaving differently.
Improves on the support previously added for v1.60 This should be much more complete with respect to changes introduced since 1.51 Some work still required for autodoc redefines since 1.51
…objects() *before* calling destroy_context()
|
Wow, that's huge and impressive. I will start reviewing it now and tell when I'm done. It may take some time because this PR is very long. Removing obsolete/deprecated functionalities is fine for me. We will make it as 1.0.0 release and leave notes about introduced backward-incompatibilty. This is what I've have already planned to do when @pconerly started his work on 1.51 update in #61. I think that we can close the #72 and focus on this one. |
|
This is awesome! If that means that #61 should just get closed, that's fine. It'd be great if we could document the missing functionality though, and carve those out as tickets that people can pick up. |
input_int, incorrectly referenced input_float additional visual-doc examples: input_double slider_float slider_float2 slider_float3 slider_int slider_int2 slider_int3 v_slider_int v_slider_float
|
Thanks guys. I got restless and added a few more visual-doc examples - that should bring the coverage checks back up. I've also added the remaining enum redeclaractions. I'll leave this pull request as it for now for a proper review, but any/all feedback is welcome. I hope I'm not stepping on any toes here. This is my first set of pull requests, so.. proper etiquette and all that. |
|
Sorry it took me that much time. I had a pretty intense week. This is great and you're not stepping on any toes here. I'm pretty sure that everyone will appreciate your tremendous work here. There are few places where docstrings could be reformatted but I will do it by myself. I'm merging it. This is huge change so I was thinking about doing at least one pre-release version before the official 1.0.0. What do you think about that? |
|
Pre-release sound like a good idea, definitely.
Actually I started building out a python implementation of ShowDemoWindow()
but quickly encountered the "inout" problems discussed in issue #8
While not relevant for this pull request, is it worth considering issue #8
before a 1.0 release?
…On Tue, 22 May 2018 at 11:22, Michał Jaworski ***@***.***> wrote:
Merged #73 <#73>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#73 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ASusYNe6YOJxSjyr1B1wr_Jrm8XWlDe2ks5t0-cBgaJpZM4UAJvd>
.
|
|
I have released these changes as a prerrelese on PyPI. More details here. Unfortunately wheels for Windows are still missing because AppVeyor build got stuck. When they are ready I will upload them to PyPI. |
|
Released as |
4 participants
Further to the previous pull request for v1.60
This builds on that with support for v1.61
This pull request is much more complete than 1.60 (and includes all the changes that should have been included in v1.60)
Much greater care has been taken to ensure all relevant changes since v1.51 are incorporated (outside of new functionality).
Note that this branch intentionally excludes any obsolete/deprecated functionality.
The only outstanding item (AFAIK) is to update init.py with redeclarations to support autodoc.