Additional funcs 20180527 #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AddRectFilled GetVersion GetCursorStartPos GetCursorScreenPos GetTextLineHeight GetTextLineHeightWithSpacing GetFrameHeight GetFrameHeightWithSpacing GetStyleColorName Also added (but plan to refactor into a single-dispatch mechanism): GetColorU32
StyleColorsDark
StyleColorsClassic
StyleColorsLight
SetItemDefaultFocus
SetKeyboardFocusHere
SetItemDefaultFocus
SetKeyboardFocusHere
SetItemDefaultFocus
SetKeyboardFocusHere
Increases coverage to include add_draw_rect and get_color_u32
|
Yeah, I will try to think what to do with these functions. Maybe this week as I have a free weekend this time. Great work anyway. By the way, I will try to do promised prerelease today. I have already configured sphinx build in RTD to show proper versions after this lands on master to avoid confusion. |
|
I have released these changes as a prerrelese on PyPI. More details here. Unfortunately wheels for Windows are still missing because AppVeyor build got stuck. When they are ready I will upload them to PyPI. |
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for
Regarding GetColorU32.. These are overloaded functions in ImGui, and I was unable to find any way of supporting single/multiple dispatch with Cython.
That means we're left with 3 distinct cpdefs in order to support the 3 function signatures.