Playground -- update janet and improved mechanism for formatting #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @swlkr just wanted to make sure you saw this PR. Mainly updating Janet wasm to recent version for the playground. |
|
You know what, I did see this and then I promptly forgot :( and then forgot again :( LGTM |
|
Haha. Thanks!
Mike
…On Wed, Jul 7, 2021 at 7:27 PM Sean Walker ***@***.***> wrote:
Merged #39 <#39> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM7HKT4Z4IZKUZ2SEYX4F3TWTPFFANCNFSM46PNUFMA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @swlkr -- I am submitting this PR to update the janet WASM artifacts in janetdocs to v1.16.1. Seems like somewhere along the line I also changed the way format works (to include spork into the wasm image and use spork's formatter) and it looks like that was not yet merged, so you get two for the price of one. :-) cheers.