Support CURLOPT_RESOLVE option for SWOOLE_HOOK_CURL #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twose
requested changes
May 28, 2021
src/core/Curl/Handler.php
Outdated
| @@ -412,6 +426,15 @@ private function setOption(int $opt, $value): bool | |||
| $this->nobody = boolval($value); | |||
| $this->method = 'HEAD'; | |||
| break; | |||
| case CURLOPT_RESOLVE: | |||
| foreach ((array) $value as $resolve) { | |||
| $tmpResolve = explode(':', $resolve); | |||
There was a problem hiding this comment.
curl的格式要求是[+]HOST:PORT:ADDRESS[,ADDRESS]...
这里没有处理前导加号也没有处理多地址
There was a problem hiding this comment.
看一些sdk里用到的都是一个[HOST:PORT:ADDRESS]，PHP这里应该不需要支持多地址吧
PHP curl 多地址: [HOST:PORT:ADDRESS], [HOST:PORT:ADDRESS]后面的会覆盖前面的，[HOST:PORT:ADDRESS,ADDRESS]读的前面的
twose
requested changes
May 28, 2021
src/core/Curl/Handler.php
Outdated
| @@ -412,6 +426,15 @@ private function setOption(int $opt, $value): bool | |||
| $this->nobody = boolval($value); | |||
| $this->method = 'HEAD'; | |||
| break; | |||
| case CURLOPT_RESOLVE: | |||
| foreach ((array) $value as $resolve) { | |||
| $tmpResolve = explode(':', $resolve); | |||
There was a problem hiding this comment.
curl的格式要求是[+]HOST:PORT:ADDRESS[,ADDRESS]...
这里没有处理前导加号也没有处理多地址
deminy
reviewed
Jun 30, 2021
deminy
reviewed
Jul 8, 2021
There was a problem hiding this comment.
Some of following cases not yet covered.
#!/usr/bin/env bash
set -x
curl -i \
--resolve "+httpbin.org:443:127.0.0.1" \
https://httpbin.org/get
curl -i \
--resolve "httpbin.org:443:127.0.0.1" \
--resolve "httpbin.org:443:$(dig +short httpbin.org | head -n 1)" \
https://httpbin.org/get
curl -i \
--resolve "httpbin.org:443:$(dig +short httpbin.org | head -n 1)" \
--resolve "+httpbin.org:443:127.0.0.1" \
https://httpbin.org/get
curl -i \
--resolve "httpbin.org:443:$(dig +short httpbin.org | head -n 1)" \
--resolve "httpbin.org:443:127.0.0.1" \
https://httpbin.org/get
curl -i \
--resolve "httpbin.org:443:$(dig +short httpbin.org | head -n 1)" \
--resolve "httpbin.org:443:127.0.0.1" \
--resolve "-httpbin.org:443:127.0.0.1" \
https://httpbin.org/getPersonally, I feel it should be fine to treat +HOST:... the same as HOST:... in the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix swoole/swoole-src#4219