Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CURLOPT_HTTPPROXYTUNNEL for SWOOLE_HOOK_CURL #126

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Support CURLOPT_HTTPPROXYTUNNEL for SWOOLE_HOOK_CURL #126

merged 1 commit into from
Oct 27, 2021

Conversation

sy-records
Copy link
Member

Ignore CURLOPT_HTTPPROXYTUNNEL

@sy-records sy-records requested a review from twose October 21, 2021 01:34
@twose
Copy link
Member

twose commented Oct 22, 2021

我不清楚是否应该忽略,或者是否是设置为0的时候才忽略,设置为1的时候报错

@sy-records
Copy link
Member Author

嗯... 不太清楚行为是什么,文档说的是 true 会通过指定的 HTTP 代理来传输,那就是指定proxy的时候了

如果加上这个选项以后,proxy的行为就可能不一致了

@matyhtf
Copy link
Member

matyhtf commented Oct 27, 2021

CURLOPT_HTTPPROXYTUNNEL 只用于非 http/https 协议,而 swoole 只允许 http/https 协议,因此可以忽略此参数

@matyhtf matyhtf closed this Oct 27, 2021
@matyhtf matyhtf reopened this Oct 27, 2021
@matyhtf matyhtf merged commit fb28dcb into swoole:master Oct 27, 2021
@sy-records sy-records deleted the curl/61 branch October 27, 2021 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants