Added Http\Response::isWritable(), fix #3955

Author: matyhtf

ext-src/swoole_http_response.cc

@@ -165,6 +165,7 @@ static PHP_METHOD(swoole_http_response, cookie);
 static PHP_METHOD(swoole_http_response, rawcookie);
 static PHP_METHOD(swoole_http_response, header);
 static PHP_METHOD(swoole_http_response, initHeader);
+static PHP_METHOD(swoole_http_response, isWritable);
 static PHP_METHOD(swoole_http_response, detach);
 static PHP_METHOD(swoole_http_response, create);
 /**
@@ -251,6 +252,7 @@ ZEND_END_ARG_INFO()
 const zend_function_entry swoole_http_response_methods[] =
 {
     PHP_ME(swoole_http_response, initHeader, arginfo_swoole_http_void, ZEND_ACC_PUBLIC)
+    PHP_ME(swoole_http_response, isWritable, arginfo_swoole_http_void, ZEND_ACC_PUBLIC)
     PHP_ME(swoole_http_response, cookie, arginfo_swoole_http_response_cookie, ZEND_ACC_PUBLIC)
     PHP_MALIAS(swoole_http_response, setCookie, cookie, arginfo_swoole_http_response_cookie, ZEND_ACC_PUBLIC)
     PHP_ME(swoole_http_response, rawcookie, arginfo_swoole_http_response_cookie, ZEND_ACC_PUBLIC)
@@ -701,6 +703,14 @@ static PHP_METHOD(swoole_http_response, initHeader) {
     RETURN_TRUE;
 }
 
+static PHP_METHOD(swoole_http_response, isWritable) {
+    http_context *ctx = php_swoole_http_response_get_context(ZEND_THIS);
+    if (!ctx || (ctx->end || ctx->detached)) {
+        RETURN_FALSE;
+    }
+    RETURN_TRUE;
+}
+
 static PHP_METHOD(swoole_http_response, end) {
     http_context *ctx = php_swoole_http_response_get_and_check_context(ZEND_THIS);
     if (UNEXPECTED(!ctx)) {

tests/swoole_http_server/0.phpt

@@ -0,0 +1,43 @@
+--TEST--
+swoole_http_server: basic functions
+--SKIPIF--
+<?php require __DIR__ . '/../include/skipif.inc'; ?>
+--FILE--
+<?php
+require __DIR__ . '/../include/bootstrap.php';
+
+$pm = new ProcessManager;
+
+$html = base64_encode(random_bytes(rand(2048, 65536)));
+
+$pm->parentFunc = function ($pid) use ($pm, $html) {
+    go(function () use ($pm, $html) {
+        $data = httpGetBody("http://127.0.0.1:{$pm->getFreePort()}/");
+        Assert::same($data, $html);
+        $pm->kill();
+    });
+    Swoole\Event::wait();
+    echo "DONE\n";
+};
+
+$pm->childFunc = function () use ($pm, $html) {
+    $serv = new swoole_http_server('127.0.0.1', $pm->getFreePort(), SWOOLE_BASE);
+    $serv->set([
+        'log_file' => '/dev/null',
+    ]);
+    $serv->on("workerStart", function ($serv) use ($pm) {
+        $pm->wakeup();
+    });
+    $serv->on('request', function ($req, $resp) use ($html) {
+        Assert::true($resp->isWritable());
+        $resp->end($html);
+        Assert::false($resp->isWritable());
+    });
+    $serv->start();
+};
+
+$pm->childFirst();
+$pm->run();
+?>
+--EXPECT--
+DONE