Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coredump: when stream context is null #4016

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

ZhiyangLeeCN
Copy link
Contributor

Function md5_file internal call php_stream_open_wrapper macro open stream according to filename argument passed function, this macro use is null stream context and send to _php_stream_open_wrapper_ex , but function socket_enable_crypto in ext-src/swoole_runtime.cc not check stream context is null, when use https url send to functionmd5_file occur coredump.

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #4016 (f2d886b) into master (b1a0dcc) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4016      +/-   ##
==========================================
- Coverage   49.35%   49.22%   -0.14%     
==========================================
  Files          69       69              
  Lines       13063    13063              
==========================================
- Hits         6447     6430      -17     
- Misses       6616     6633      +17     
Impacted Files Coverage Δ
src/os/async_thread.cc 66.37% <0.00%> (-3.50%) ⬇️
src/core/channel.cc 70.87% <0.00%> (-0.98%) ⬇️
src/coroutine/socket.cc 41.95% <0.00%> (-0.54%) ⬇️
src/server/port.cc 53.74% <0.00%> (-0.33%) ⬇️
src/network/socket.cc 58.15% <0.00%> (-0.22%) ⬇️
src/network/client.cc 44.42% <0.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a0dcc...f2d886b. Read the comment docs.

@matyhtf matyhtf merged commit 1ee4182 into swoole:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants