Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting content-length HTTP header in application layer #4041

Merged
merged 3 commits into from
Feb 7, 2021

Conversation

doubaokun
Copy link
Contributor

Allow application set the content-length HTTP header if the content length is known.

User set content-length header is overriding the body length calculated by server.

Ref: #3901

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #4041 (cf7af80) into master (bcf418f) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4041      +/-   ##
==========================================
- Coverage   47.78%   47.72%   -0.06%     
==========================================
  Files          71       71              
  Lines       14266    14266              
==========================================
- Hits         6817     6809       -8     
- Misses       7449     7457       +8     
Impacted Files Coverage Δ
src/protocol/base.cc 61.43% <0.00%> (-1.97%) ⬇️
src/core/channel.cc 70.87% <0.00%> (-0.98%) ⬇️
src/network/client.cc 45.24% <0.00%> (-0.46%) ⬇️
src/network/socket.cc 47.54% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcf418f...cf7af80. Read the comment docs.

@matyhtf matyhtf merged commit a1cef6e into master Feb 7, 2021
@matyhtf matyhtf deleted the set_content_length branch February 7, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants