Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not serializable classes for 8.1.0beta1 #4335

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

remicollet
Copy link
Contributor

From UPGRADING.INTERNALS

 f. Non-serializable classes should be indicated using the
     ZEND_ACC_NOT_SERIALIZABLE (@not-serializable in stubs) rather than the
     zend_class_(un)serialize_deny handlers which are removed.

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #4335 (e52686d) into master (029f174) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4335      +/-   ##
==========================================
+ Coverage   50.62%   50.68%   +0.06%     
==========================================
  Files          72       72              
  Lines       14516    14516              
==========================================
+ Hits         7349     7358       +9     
+ Misses       7167     7158       -9     
Impacted Files Coverage Δ
src/os/process_pool.cc 57.89% <0.00%> (+0.45%) ⬆️
src/os/async_thread.cc 68.85% <0.00%> (+1.75%) ⬆️
src/protocol/base.cc 63.15% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029f174...e52686d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants