Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client side support ssl_ciphers config #4432

Merged
merged 1 commit into from
Oct 13, 2021
Merged

client side support ssl_ciphers config #4432

merged 1 commit into from
Oct 13, 2021

Conversation

amuluowin
Copy link
Contributor

like title.

@amuluowin
Copy link
Contributor Author

这里有个疑问,keep_alive的时候,是否需要判断如果已经设置了ssl_ciphers则忽略新的设置,同一个链接应该同一个ssl_ciphers.

@matyhtf
Copy link
Member

matyhtf commented Oct 13, 2021

@amuluowin 这些底层已经处理好了,如果是复用了 socket 不需要重新设置,如果是新建的连接会读取 setting 设置到新的 socket 上

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #4432 (dad1eb6) into master (372fdb8) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4432      +/-   ##
==========================================
- Coverage   52.41%   52.36%   -0.06%     
==========================================
  Files          73       73              
  Lines       14882    14882              
==========================================
- Hits         7801     7793       -8     
- Misses       7081     7089       +8     
Impacted Files Coverage Δ
src/protocol/base.cc 61.18% <0.00%> (-1.98%) ⬇️
src/os/async_thread.cc 71.24% <0.00%> (-0.86%) ⬇️
src/network/client.cc 46.46% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 372fdb8...dad1eb6. Read the comment docs.

@matyhtf matyhtf merged commit 1bc3917 into swoole:master Oct 13, 2021
huanghantao pushed a commit that referenced this pull request Oct 13, 2021
matyhtf added a commit that referenced this pull request Oct 14, 2021
* Update version for Swoole 4.8.0

* Added release permission

* Update package.xml

* Added release permission

* Revert "Added release permission"

This reverts commit 7b62768.

* client support ssl_ciphers config (#4432)

* Update version for Swoole 4.8.0

Co-authored-by: Bruce Dou <doubaokun@gmail.com>
Co-authored-by: matyhtf <mikan.tenny@gmail.com>
Co-authored-by: albert <amuluowin@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants