Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1.3] Fix broken build with GCC 14 #5363

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Conversation

remicollet
Copy link
Contributor

1/ [-Wimplicit-function-declaration]

/builddir/build/BUILD/php83-php-pecl-swoole5-5.1.3/swoole-5.1.3/thirdparty/php83/pdo_odbc/odbc_driver.c: In function 'pdo_odbc_handle_factory':
/builddir/build/BUILD/php83-php-pecl-swoole5-5.1.3/swoole-5.1.3/thirdparty/php83/pdo_odbc/odbc_driver.c:536:18: error: implicit declaration of function 'php_odbc_connstr_is_quoted' [-Wimplicit-function-declaration]
  536 |                 !php_odbc_connstr_is_quoted(dbh->username) && php_odbc_connstr_should_quote(dbh->username);
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
/builddir/build/BUILD/php83-php-pecl-swoole5-5.1.3/swoole-5.1.3/thirdparty/php83/pdo_odbc/odbc_driver.c:536:63: error: implicit declaration of function 'php_odbc_connstr_should_quote' [-Wimplicit-function-declaration]
  536 |                 !php_odbc_connstr_is_quoted(dbh->username) && php_odbc_connstr_should_quote(dbh->username);
      |                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/builddir/build/BUILD/php83-php-pecl-swoole5-5.1.3/swoole-5.1.3/thirdparty/php83/pdo_odbc/odbc_driver.c:540:43: error: implicit declaration of function 'php_odbc_connstr_estimate_quote_length' [-Wimplicit-function-declaration]
  540 |                 size_t estimated_length = php_odbc_connstr_estimate_quote_length(dbh->username);
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/builddir/build/BUILD/php83-php-pecl-swoole5-5.1.3/swoole-5.1.3/thirdparty/php83/pdo_odbc/odbc_driver.c:542:17: error: implicit declaration of function 'php_odbc_connstr_quote' [-Wimplicit-function-declaration]
  542 |                 php_odbc_connstr_quote(uid, dbh->username, estimated_length);
      |                 ^~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:618: thirdparty/php83/pdo_odbc/odbc_driver.lo] Error 1

2/ [-Wimplicit-int]

In file included from /builddir/build/BUILD/php83-php-pecl-swoole5-5.1.3/swoole-5.1.3/thirdparty/php83/pdo_sqlite/sqlite_driver.c:18:
/builddir/build/BUILD/php83-php-pecl-swoole5-5.1.3/swoole-5.1.3/thirdparty/php83/pdo_sqlite/sqlite_driver.c: In function 'do_callback':
/builddir/build/BUILD/php83-php-pecl-swoole5-5.1.3/swoole-5.1.3/ext-src/php_swoole_call_stack.h:21:10: error: type defaults to 'int' in declaration of '__stack_limit' [-Wimplicit-int]
   21 |     auto __stack_limit = EG(stack_limit);                                                                              \
      |          ^~~~~~~~~~~~~

@remicollet remicollet changed the title Fix broken build with GCC 14 [5.1.3] Fix broken build with GCC 14 Jun 6, 2024
@remicollet
Copy link
Contributor Author

Notice: these are errors with GCC14, but warnings with older GCC, so need to be fixed.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.57%. Comparing base (8e8db8b) to head (c127c74).

Additional details and impacted files
@@            Coverage Diff             @@
##            5.1.x    #5363      +/-   ##
==========================================
+ Coverage   71.55%   71.57%   +0.01%     
==========================================
  Files         105      105              
  Lines       16088    16088              
  Branches     2972     2972              
==========================================
+ Hits        11512    11515       +3     
+ Misses       4522     4518       -4     
- Partials       54       55       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matyhtf matyhtf merged commit 852eda0 into swoole:5.1.x Jun 6, 2024
37 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants