Support ROS Melodic #514
Support ROS Melodic #514
Conversation
|
Note that the melodic CI build will fail until ros/rosdistro#17809 is merged and the package has been built on the build farm. |
| @@ -4,14 +4,14 @@ marti\_common ['s [Intelligent Vehicle Systems](http://www.swri.org/4org/d10/isd/ivs/default.htm) section for working with [Robot Operating System(ROS)](http://www.ros.org). | |||
|
|
|||
| Installation (ROS Indigo, Jade, Kinetic, Lunar) | |||
| Installation (ROS Indigo, Kinetic, Lunar, Melodic) | |||
There was a problem hiding this comment.
You could have kept Jade in there, unless OSRF is no longer hosting the repo.
There was a problem hiding this comment.
I think they're still hosting it, but it's been past EOL for a year now, they're no longer accepting releases into it, and I'm not planning to fix it if something breaks. I didn't want to give a misleading impression that we were still supporting it, although I suppose it's not a big deal either way. Do you think it's worth leaving in there?
| @@ -64,7 +64,11 @@ namespace swri_opencv_util | |||
| } | |||
| } | |||
|
|
|||
| #if (BOOST_VERSION / 100 % 1000) >= 65 | |||
There was a problem hiding this comment.
Oh wow this is actually the supported way of detecting the boost version. Eww.
There was a problem hiding this comment.
Yeah, that's the same face I made. Oh, boost.
Ubuntu 18.04 comes with boost 1.65.1, and the usage of the
boost::serialization::singletonclass changed slightly in it (see https://www.boost.org/doc/libs/1_65_0/libs/serialization/doc/singleton.html ). This will make marti_common compile properly on 18.04 / Melodic.