Query window pixel size #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swsnr
force-pushed
the
get-term-size-directly
branch
2 times, most recently
from
1339fd9
to
e88bd82
Compare
mdcat needs the window size in pixels to correctly draw images in some terminals. Unfortunately term_size doesn't expose ws_xpixel/ws_ypixel from the winsize struct so we now do the ioctl ourselves. This effectively gets rid of term_size on Unix system which has the added benefit that we can now freely choose which device to query instead of being limited to stdin, stdout and stderr. We use this opportunity to query the controlling terminal directly, via ctermid. This implies that mdcat correctly detects the terminal size even when all standard streams are redirected.
No longer run kitty icat --print-window-size to determine the window size in pixels; instead rely on what we've got from the terminal directly (kitty icat --print-window-size does nothing different). This is simpler, faster and, above all, works over SSH connections.
swsnr
force-pushed
the
get-term-size-directly
branch
from
556bb30
to
4335fc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query the window pixel size from the underlying terminal, and use it for Kitty image drawing.
Since term_size doesn't expose
ws_xpixel/ws_ypixel(see clap-rs/term_size-rs#33) we do theioctlourselves. Getting rid ofterm_sizealso allows us to query the controlling terminal withctermid(whichterm_sizedoesn't support either, see clap-rs/term_size-rs#34), which works even when all standard streams are redirected.