Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sign up frontend and fix promise warnings in jest #30

Merged
merged 5 commits into from
Nov 1, 2019

Conversation

HaeSe0ng
Copy link
Contributor

@HaeSe0ng HaeSe0ng commented Oct 31, 2019

Implemented sign up frontend and fixed promise warnings in jest

Description

프로미스 워닝 없애기 위해 catch 넣었습니다. store/action/user.test.js, match.test.js 에 관련 테스트 추가했으니 나중에 에러 핸들링 해주세요.
나머지 커밋 설명은 Issue #43, #44 참고

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@eodmsabc
Copy link
Contributor

CI checks have not been performed properly.

Copy link
Contributor

@eodmsabc eodmsabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@eodmsabc eodmsabc merged commit b9046df into master Nov 1, 2019
@uyw4687 uyw4687 deleted the signup branch November 3, 2019 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants