Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shinydashboardplusの新パラメータの対応 #2624

Merged
merged 3 commits into from
Sep 12, 2020
Merged

shinydashboardplusの新パラメータの対応 #2624

merged 3 commits into from
Sep 12, 2020

Conversation

swsoyee
Copy link
Owner

@swsoyee swsoyee commented Aug 19, 2020

Close #2623

@swsoyee swsoyee self-assigned this Aug 19, 2020
@swsoyee swsoyee requested a review from Bob-FU August 19, 2020 15:42
@Bob-FU
Copy link
Collaborator

Bob-FU commented Aug 19, 2020

旧バージョンshinydashboardplus入のDockerImageで試した結果、メイン画面が開けなくなったことを確認。
後方互換性がないことがわかった。

 8月 20 01:44:06 debian-4gb-hel1-1 docker-compose[19107]: shinystg |
 8月 20 01:44:06 debian-4gb-hel1-1 docker-compose[19107]: shinystg | Listening on http://127.0.0.1:33625
 8月 20 01:44:06 debian-4gb-hel1-1 docker-compose[19107]: shinystg | Warning: Error in descriptionBlock: unused arguments (numberColor = "yellow", numberIcon = getChangeIconWrapper(sum(mhlwSummary[日付 == max(日付) & 分類 %in% 0:2]$検査人数) - s
 8月 20 01:44:06 debian-4gb-hel1-1 docker-compose[19107]: shinystg |   92: dots_list
 8月 20 01:44:06 debian-4gb-hel1-1 docker-compose[19107]: shinystg |   91: div
 8月 20 01:44:06 debian-4gb-hel1-1 docker-compose[19107]: shinystg |   90: column
 8月 20 01:44:10 debian-4gb-hel1-1 docker-compose[19107]: shinystg |

リリース時要注意。

@swsoyee swsoyee mentioned this pull request Aug 20, 2020
Open
@XiangyunHuang XiangyunHuang mentioned this pull request Sep 11, 2020
Merged
7 tasks
Bob-FU
Bob-FU approved these changes Sep 12, 2020
View reviewed changes
Copy link
Collaborator

@Bob-FU Bob-FU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server component updated.

@Bob-FU Bob-FU merged commit 228a767 into master Sep 12, 2020
@Bob-FU Bob-FU deleted the fix-shinydashboardplus-new-version branch September 12, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bob-FU Bob-FU Bob-FU approved these changes

Assignees

@swsoyee swsoyee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

【バージョン対応】shinydashboardPlus
2 participants
@swsoyee @Bob-FU