Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 3Dmol.js to 1.6.2 #12

Merged
merged 4 commits into from
Feb 18, 2021
Merged

Update 3Dmol.js to 1.6.2 #12

merged 4 commits into from
Feb 18, 2021

Conversation

BradyAJohnston
Copy link
Collaborator

@BradyAJohnston BradyAJohnston commented Feb 17, 2021 •
edited
Loading

Addressing #10 (comment) to update to the latest available github build of 3Dmol.js.

swsoyee
swsoyee approved these changes Feb 18, 2021
View reviewed changes
Copy link
Owner

@swsoyee swsoyee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Unfortunately the differences are still lost be everything seems to be fine.

swsoyee
swsoyee requested changes Feb 18, 2021
View reviewed changes
inst/htmlwidgets/r3dmol.yaml Show resolved Hide resolved
inst/htmlwidgets/r3dmol.yaml Show resolved Hide resolved
@swsoyee swsoyee merged commit 362f493 into swsoyee:master Feb 18, 2021
@swsoyee swsoyee mentioned this pull request Feb 18, 2021
Closed
@swsoyee swsoyee linked an issue Feb 18, 2021 that may be closed by this pull request
Upgrade 3dmol.js to the latest version (v1.6.2) #10
Closed
@swsoyee swsoyee added this to the v0.1.2 milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swsoyee swsoyee swsoyee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.2
Development

Successfully merging this pull request may close these issues.

Upgrade 3dmol.js to the latest version (v1.6.2)
2 participants
@BradyAJohnston @swsoyee