Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add page object to the event pagePreloaded #65

Merged
merged 1 commit into from
May 13, 2023
Merged

Add page object to the event pagePreloaded #65

merged 1 commit into from
May 13, 2023

Conversation

hirasso
Copy link
Member

@hirasso hirasso commented May 12, 2023

Fixes #64

Description

From the readme:

swup.on('pagePreloaded', (page) => console.log('preloaded:' page));

The page object is not being passed to the event right now. This PR fixes that.

Checks

  • The PR is submitted to the master branch

@hirasso
Add page object to the event pagePreloaded
466e0ef 
Behavior as described in the readme
@hirasso hirasso mentioned this pull request May 12, 2023
Closed
@hirasso hirasso requested review from daun and gmrchk May 12, 2023 12:07
@hirasso hirasso merged commit 483346c into master May 13, 2023
@hirasso hirasso deleted the add-context-to-page-preloaded branch May 13, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daun daun daun approved these changes

@gmrchk gmrchk Awaiting requested review from gmrchk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'pagePreloaded' event doesn't pass any arguments
2 participants
@hirasso @daun