Add atan2 for DataVector #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wthrowe
reviewed
Oct 27, 2017
| @@ -14,7 +14,7 @@ See LICENSE.txt for details. | |||
| * [Charm++](http://charm.cs.illinois.edu/) 6.8 or newer (must be compiled from source) | |||
| * [Git](https://git-scm.com/) | |||
| * BLAS (e.g. [OpenBLAS](http://www.openblas.net)) | |||
| * [Blaze](https://bitbucket.org/blaze-lib/blaze/overview) | |||
| * [Blaze](https://bitbucket.org/blaze-lib/blaze/overview) v3.2 | |||
There was a problem hiding this comment.
Is it worth enforcing this in CMake?
There was a problem hiding this comment.
Yes, I'll have to see if there's a way to do that. I posted a similar question as an issue on the Blaze repo: https://bitbucket.org/blaze-lib/blaze/issues/138/check-blaze-version
nilsdeppe
changed the title
nilsdeppe
changed the title
nilsdeppe
force-pushed
the
datavector_atan2
branch
from
cbb7e22
to
d2ed655
Compare
|
This depends on #315 for Blaze's find_package updates. Before this can be merged the buildenv will need to be updated, which I'm working on now. Spack has merged the PR mentioned in the description. |
nilsdeppe
force-pushed
the
datavector_atan2
branch
from
d2ed655
to
0f04343
Compare
kidder
previously approved these changes
Nov 2, 2017
src/Utilities/PointerVector.hpp
Outdated
| @@ -6,16 +6,99 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <cmath> | |||
| #include "Utilities/Blaze.hpp" | |||
nilsdeppe
force-pushed
the
datavector_atan2
branch
from
0f04343
to
5ab72cf
Compare
Codecov Report
@@ Coverage Diff @@
## develop #304 +/- ##
===========================================
+ Coverage 98.51% 98.52% +<.01%
===========================================
Files 177 178 +1
Lines 6614 6641 +27
===========================================
+ Hits 6516 6543 +27
Misses 98 98
Continue to review full report at Codecov.
|
kidder
previously approved these changes
Nov 2, 2017
nilsdeppe
force-pushed
the
datavector_atan2
branch
from
5ab72cf
to
bd6c60a
Compare
nilsdeppe
force-pushed
the
datavector_atan2
branch
from
bd6c60a
to
72f2cc9
Compare
kidder
approved these changes
Nov 3, 2017
kidder
requested changes
Nov 4, 2017
|
Okay, pushed a commit that should fix this |
kidder
approved these changes
Nov 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be rebased after #303 is merged, and should only be merged after https://github.com/LLNL/spack/pull/5992 is merged into spack