Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase timeout of control system Shape test #4667

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Increase timeout of control system Shape test #4667

merged 1 commit into from
Jan 30, 2023

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Jan 30, 2023

Proposed changes

I've been seeing this on CI a lot lately.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 added the small Only changes a few lines of code, does a rename or is otherwise quick to review label Jan 30, 2023
@nilsdeppe nilsdeppe merged commit 8296901 into sxs-collaboration:develop Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsdeppe nilsdeppe nilsdeppe approved these changes

Assignees
No one assigned
Labels
small Only changes a few lines of code, does a rename or is otherwise quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knelli2 @nilsdeppe