Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use charm built with gcc on CI #4677

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Feb 1, 2023

On both local and Wheeler, I've been using charm built with gcc but SpECTRE built with clang and I've had no issues

Proposed changes

Separated from #4673 so we don't interrupt CI when we update the docker container.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

On both local and Wheeler, I've been using charm built with gcc
but SpECTRE built with clang and I've had no issues
@knelli2 knelli2 requested a review from nilsvu February 1, 2023 01:22
@knelli2 knelli2 mentioned this pull request Feb 1, 2023
3 tasks
@wthrowe
Copy link
Member

wthrowe commented Feb 1, 2023

As an additional data point, I've also been using one charm build with different compilers without a problem on my dev machine.

@nilsvu
Copy link
Member

nilsvu commented Feb 1, 2023

The two clang Release builds took a very long time because their cache was invalidated by this change. Not really sure what to do about that. I restarted them for now.

@nilsvu nilsvu merged commit 497ec24 into sxs-collaboration:develop Feb 2, 2023
@nilsvu
Copy link
Member

nilsvu commented Feb 2, 2023

They passed now, so I'm merging this and hoping for caching to kick in. The one clang release build took a scary 5.5h though, so we may have to do something about build times soon..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants