Add input file for head-on BNS initial data #4683
Conversation
tests/InputFiles/Xcts/HeadOnBns.yaml
Outdated
| XCoords: [&x_left -20., &x_right 20.] | ||
| ObjectA: &star_right | ||
| TovStar: | ||
| CentralDensity: 0.0008087415253997405 # h = 1.2 |
There was a problem hiding this comment.
Where does this and the K come from? In single stars K=100 is standard and gives a maximum mass of the NS that's ~2.2 M_sun. Also, can you use scientific notation here? I find it rather difficult to parse all the leading zeroes. 8.08e-4 is much easier to read. Also, having the central density in terms of g/cm^3 in the comment would be more helpful than the specific enthalpy.
There was a problem hiding this comment.
Added the reference where these numbers are from, and the other things. Thanks for your review!
|
RIP, all CI failed... |
| ObjectA: &star_right | ||
| TovStar: | ||
| # Values taken from Sec. V.C and Fig. 8 in | ||
| # https://arxiv.org/abs/1708.07358. |
There was a problem hiding this comment.
I think we should use the numbers from https://arxiv.org/pdf/2010.14518.pdf instead. It's more recent and also evolves the binaries, and allows for a simple thermal component.
There was a problem hiding this comment.
You can replace this with an EOS of your choice when generating ID :) happy to put another one here as the example. The paper you link doesn't
list the central density though, or maybe I've missed it. Also, is the thermal component implemented?
There was a problem hiding this comment.
Okay, let's just leave it as-is. Like you said, we can adjust later :)
|
Conflict with #4684 that was merged earlier |
Proposed changes
Generates this matter & gravity configuration:
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments