Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: can を追加 #20

Merged
merged 37 commits into from
Dec 11, 2023
Merged

feat: can を追加 #20

merged 37 commits into from
Dec 11, 2023

Conversation

wakky-alcedo
Copy link
Collaborator

No description provided.

@sya-ri sya-ri changed the title add(can): can を HAL_Extension に追加 feat: can を HAL_Extension に追加 Dec 8, 2023
sya-ri
sya-ri reviewed Dec 8, 2023
View reviewed changes
Copy link
Owner

@sya-ri sya-ri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多くなりすぎたのでひとまず送ります。ある程度修正し終わったら再度確認します

can/can_class_setting_status.hpp Outdated Show resolved Hide resolved
can/can_filter_mode.hpp Outdated Show resolved Hide resolved
can/can.hpp Outdated Show resolved Hide resolved
can/can_class_setting_status.hpp Outdated Show resolved Hide resolved
can/can_status_type.hpp Outdated Show resolved Hide resolved
can/can.cpp Outdated Show resolved Hide resolved
can/can.cpp Outdated Show resolved Hide resolved
can/can.cpp Outdated Show resolved Hide resolved
can/can.cpp Outdated Show resolved Hide resolved
can/can.hpp Outdated Show resolved Hide resolved
sya-ri
sya-ri requested changes Dec 8, 2023
View reviewed changes
Copy link
Owner

@sya-ri sya-ri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正お願いします！修正しおわったら 「XXXXXX で修正しました」というメッセージを送って Resolve conversation してください。XXXXXX はコミットハッシュです。そのコミットで問題なく修正されているか確認します

@sya-ri sya-ri changed the title feat: can を HAL_Extension に追加 feat: can wo追加 Dec 8, 2023
@sya-ri sya-ri changed the title feat: can wo追加 feat: can を追加 Dec 8, 2023
@sya-ri sya-ri mentioned this pull request Dec 8, 2023
Open
13 tasks
sya-ri
sya-ri reviewed Dec 10, 2023
View reviewed changes
can/can.hpp Outdated Show resolved Hide resolved
@sya-ri sya-ri marked this pull request as ready for review December 10, 2023 11:58
@sya-ri sya-ri self-assigned this Dec 10, 2023
@sya-ri
Copy link
Owner

sya-ri commented Dec 10, 2023

@alcedo-taku リファクタ終わりました

@sya-ri sya-ri merged commit ebe8b9e into sya-ri:dev Dec 11, 2023
@sya-ri sya-ri deleted the feature/can branch December 11, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sya-ri sya-ri sya-ri approved these changes

Assignees

@sya-ri sya-ri

@wakky-alcedo wakky-alcedo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wakky-alcedo @sya-ri