Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fd no longer exits magit buffers. #4924

Closed
synic opened this issue Feb 1, 2016 · 7 comments
Closed

fd no longer exits magit buffers. #4924

synic opened this issue Feb 1, 2016 · 7 comments

Comments

@synic
Copy link
Contributor

synic commented Feb 1, 2016

From the documentation:

The choice of fd was made to be able to use the same sequence to escape from "everything" in Emacs:

One of the bullet points specifically mentions magit:

quit magit buffers

This no longer works. Typing f opens a menu.

I realize that you can type q to exit magit buffers, but that's not what the documentation says. It "seems" like q exits everything now, but I'm not totally sure.

Either fd in magit should be fixed, or the documentation should be fixed, it seems.

System Info

  • OS: darwin
  • Emacs: 24.5.7
  • Spacemacs: 0.105.9
  • Spacemacs branch: develop (rev. d9cf37e)
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
(unscroll auto-completion xkcd emacs-lisp git dash yaml github javascript html markdown extra-langs python ruby org osx python django syntax-checking spell-checking version-control lua colors spacemacs-layouts vimscript spacemacs-helm
          (c-c++ :variables c-c++-enable-clang-support t)
          (shell :variables shell-default-height 30 shell-default-position 'bottom))
@person808
Copy link
Contributor

Think this is a documentation issue. evil-magit uses f for fetching

@StreakyCobra
Copy link
Contributor

I tend to agree with @person808.

@nixmaniack
Copy link
Contributor

Isn't fd based on timers? Like key-chords. If that's the case it should work everywhere if pressed quickly enough.

@synic
Copy link
Contributor Author

synic commented Feb 2, 2016

I think there should be a sequence that exits everything. It's not acceptable that q, or fd should exit one type of buffer, but not another, and the user isn't going to know which is which. It's clear that having one way was the intention, but I don't know if it's truth anymore, and it's definitely not correct in the documentation.

@syl20bnr
Copy link
Owner

syl20bnr commented Feb 2, 2016

This is an issue between evil-magit and evil-escape, I'll have to check what's going on.
I don't use evil-magit so I did not catch this earlier and vice versa, the evil-magit author does not use evil-escape :-)

@syl20bnr
Copy link
Owner

syl20bnr commented Feb 2, 2016

An issue can be opened on the evil-escape repo.

@d12frosted
Copy link
Collaborator

Already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants