Use hash algorithm from Signer #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 72.78% 72.63% -0.15%
==========================================
Files 35 35
Lines 2862 2880 +18
==========================================
+ Hits 2083 2092 +9
- Misses 626 632 +6
- Partials 153 156 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tri-adam
force-pushed
the
dsse-hash-algo
branch
from
148e6a8
to
770311d
Compare
tri-adam
force-pushed
the
dsse-hash-algo
branch
from
0628e41
to
830136e
Compare
tri-adam
changed the title
tri-adam
force-pushed
the
dsse-hash-algo
branch
from
830136e
to
b191ade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
signature.Singerimplementscrypto.SignerOpts, use the hash value specified by that. Otherwise, continue to use the default value of SHA-256.Fixes #249