Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JPEGView.ini #12

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Update JPEGView.ini #12

merged 1 commit into from
Jan 30, 2022

Conversation

oughtsz
Copy link
Contributor

@oughtsz oughtsz commented Aug 9, 2021

Remove erroneous quotes around the ColorCorrection setting

When the value is enclosed in quotes, it will not be read correctly, and the program will use the hardcoded defaults instead. These defaults are the same as the defaults in the settings file, so you won't notice any difference unless you alter them.

Remove erroneous quotes around the ColorCorrection setting
@oughtsz
Copy link
Contributor Author

oughtsz commented Aug 9, 2021

I should note that changing this setting isn't normally a very good idea, just like AutoContrastCorrectionAmount and AutoBrightnessCorrectionAmount, the default setting seems perfectly calibrated to getting great results and providing the perfect range of options when you move the slider. The most useful alteration is setting it all values to 0 to turn off color correction completely.

@Bobbsterman
Copy link

Remove erroneous quotes around the ColorCorrection setting

When the value is enclosed in quotes, it will not be read correctly, and the program will use the hardcoded defaults instead. These defaults are the same as the defaults in the settings file, so you won't notice any difference unless you alter them.

Ah, that explains why my edits to that setting never changed anything! Thank you!

@sylikc sylikc added the bug Something isn't working label Oct 5, 2021
sylikc added a commit that referenced this pull request Jan 30, 2022
Close PR #12 by oughtsz https://github.com/oughtsz

fixes a bug where the quoted ColorCorrection setting causes values to be ignored and defaults set.
@sylikc sylikc merged commit 9ee2f11 into sylikc:master Jan 30, 2022
@sylikc
Copy link
Owner

sylikc commented Jan 30, 2022

@oughtsz thanks for the contribution. Sorry it took awhile to get to it and merge in the simple fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants