Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate sane default values #17

Closed
duck2 opened this issue Jul 12, 2019 · 2 comments
Closed

Generate sane default values #17

duck2 opened this issue Jul 12, 2019 · 2 comments

Comments

@duck2
Copy link
Member

duck2 commented Jul 12, 2019

I don't think our structs are zeroing out properly. Inspect and fix this.

Furthermore, default values are used in some optional attributes. It would be good to address this.

@mithro
Copy link
Member

mithro commented Jul 12, 2019

For the structures to be "Plain Old Data" types, they need to have default values of zero.

@duck2
Copy link
Member Author

duck2 commented Jul 12, 2019

I think they already have constructors&destructors due to having unique_ptr, vector and strings in them, though.

In fact, it takes considerable time to free the structures. I think this is due to the great number of std::strings.

@duck2 duck2 closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants