[explorer] fix: Expired mosaic namespace. #1193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in CreateTransaction method
✅ Deploy Preview for explorer-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Wayonb
requested changes
Aug 7, 2024
| return entry.resolved; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Should you fail if a resolved id is not found?
| transactions.map(transactionDTO => { | ||
| switch (transactionDTO.type) { | ||
| const makeTransactionLocation = (transactionInfo, secondaryId = undefined) => { | ||
| if (!transactionInfo?.height) |
There was a problem hiding this comment.
When will the transactionInfo not have a height? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the issue?
What's the fix?
resolveMosaicIdmethod.resolveMosaicIdmethod.getTransactionMosaicInfoAndNamespacemethod to process the transaction.getMosaicInfoAndNamespacemethod to accept mosaicID and transactionLocation params.mosaicDefinition,mosaicSupplyChange,mosaicAddressRestriction, andmosaicMetadata