Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hinzufügen der Funktion Skript zu verstecken #12

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Conversation

Sunnyka98
Copy link
Contributor

@Sunnyka98 Sunnyka98 commented Jun 28, 2023

Hinzufügen der Funktion das Skript für das simultanen Ausschalten zu verstecken.

close https://github.com/symcon/modules/issues/237

Doku-PR: https://github.com/symcon/site/pull/2289

@Sunnyka98 Sunnyka98 requested a review from paresy June 28, 2023 09:04
@paresy
Copy link
Collaborator

paresy commented Sep 21, 2023

Ich würde dies umdrehen und eine Property Namens "TurnOffAction" nehmen, welche standardmäßig auf "true" ist. Dann ist der Name der Checkbox in der Konfiguration klarer, als das "Read only".

Copy link
Collaborator

@paresy paresy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Siehe Kommentar

@Sunnyka98 Sunnyka98 requested a review from paresy October 17, 2023 08:57
@paresy
Copy link
Collaborator

paresy commented Mar 26, 2024

Magst du die Konflikte korrigieren? Die sind leider durch das umbenennen passiert. (Am einfachsten ist es einfach die Umbenennung nachzuziehen. Dann müssten die Konflikte weg sein)

@Sunnyka98
Copy link
Contributor Author

wurde Local getestet :

PHPUnit 11.0.0 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.15
Configuration: C:\ProgramData\Symcon\modules\Aktivliste\tests\phpunit.xml

...............                                                   15 / 15 (100%)

Time: 00:00.007, Memory: 24.00 MB

OK (15 tests, 350 assertions)

@paresy paresy merged commit c458003 into master Jun 10, 2024
2 of 4 checks passed
@paresy paresy deleted the feature/only-read branch June 10, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants