Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix, Log command outputs into the repository logs as well #53

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fix, Log command outputs into the repository logs as well #53

merged 2 commits into from
Apr 22, 2024

Conversation

bauersimon
Copy link
Member

No description provided.

@bauersimon bauersimon requested a review from zimmski April 19, 2024 12:54
@bauersimon bauersimon self-assigned this Apr 19, 2024
zimmski
zimmski reviewed Apr 19, 2024
View reviewed changes
util/exec.go Outdated Show resolved Hide resolved
zimmski
zimmski reviewed Apr 19, 2024
View reviewed changes
util/exec.go Show resolved Hide resolved
@bauersimon bauersimon force-pushed the fix-reporting branch 2 times, most recently from e8a13b8 to c2d3dca Compare April 19, 2024 14:56
@zimmski zimmski mentioned this pull request Apr 22, 2024
Merged
@zimmski zimmski assigned zimmski and unassigned bauersimon Apr 22, 2024
@zimmski zimmski changed the title Fix reporting + logging and declutter output fix, Log command outputs into the repository logs as well Apr 22, 2024
@bauersimon bauersimon requested review from zimmski and removed request for zimmski April 22, 2024 10:13
bauersimon
bauersimon commented Apr 22, 2024
View reviewed changes
cmd/eval-dev-quality/cmd/command_test.go Show resolved Hide resolved
cmd/eval-dev-quality/cmd/evaluate_test.go Show resolved Hide resolved
util/exec.go Outdated Show resolved Hide resolved
log/logger.go Show resolved Hide resolved
@bauersimon bauersimon added this to the v0.4.0 milestone Apr 22, 2024
@zimmski zimmski added the bug Something isn't working label Apr 22, 2024
@bauersimon
Copy link
Member Author

@zimmski LGTM... cannot review so please feel free to review yourself and merge xD

@zimmski zimmski merged commit 3900a48 into main Apr 22, 2024
1 check passed
@zimmski zimmski deleted the fix-reporting branch April 22, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimmski zimmski zimmski approved these changes

Assignees

@zimmski zimmski

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bauersimon @zimmski