-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow installing on PHP 8 #255
Conversation
andypost
commented
Sep 5, 2020
Q | A |
---|---|
Branch? | "master" |
Bug fix? | no |
New feature? | yes |
BC breaks? | yes/no |
Deprecations? | yes/no |
Fixed tickets | comma-separated list of tickets fixed by the PR, if any |
License | MIT |
Doc PR | reference to the documentation PR, if any |
Locally on phpunit 9 and php 8 beta3 as ter patches I'm getting
|
Another compatibility fix in separate #256 |
i have just merged #256, please rebase this branch ;-) |
After changing travis to New issues
|
Filed #259 for |
The remaining one is related to sebastianbergmann/phpunit#4373 |
great, this is green now! i wonder if we want to merge with php 8 nightly, or wait for a stable php 8 to be released first? as the nightly is only in the travis configuration it has no effect on consumers, so i would be ok to merge it now. wdyt @andypost ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as the build is green with nightly, i think it is safe enough that this package supports php 8, even if the dependencies are not yet ready
i tagged https://github.com/symfony-cmf/Routing/releases/tag/2.3.3, thanks a lot! |