Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add $priority argument to ChainRouteCollection::add() #256

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Add $priority argument to ChainRouteCollection::add() #256

merged 1 commit into from
Sep 10, 2020

Conversation

andypost
Copy link
Contributor

@andypost andypost commented Sep 5, 2020

Since symfony/routing 5.1.0 symfony/routing@4361dad route collection's add method needs extra (3rd) argument

Ref symfony/symfony#35608

Q A
Branch? "master"
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? yes
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT
Doc PR reference to the documentation PR, if any

@andypost andypost mentioned this pull request Sep 5, 2020
Merged
@dbu
Copy link
Member

dbu commented Sep 9, 2020

thanks! i fixed master branch to have styleci fixed - can you please rebase on master to see if the tests are green?

@andypost
Copy link
Contributor Author

andypost commented Sep 9, 2020

Rebased and fixed code-style for new argument

@dbu dbu merged commit dc6fe49 into symfony-cmf:master Sep 10, 2020
@dbu
Copy link
Member

dbu commented Sep 10, 2020

thanks!

@andypost andypost deleted the routes-priority branch September 10, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andypost @dbu