Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Templating changes #82

Merged
merged 3 commits into from
Jul 15, 2013
Merged

Templating changes #82

merged 3 commits into from
Jul 15, 2013

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jul 8, 2013

Q A
Bug fix? yes
New feature? yes
BC breaks? yes
Deprecations? no
Tests pass? no (will pass when sonata-project/SonataBlockBundle#80 is merged)
Fixed tickets -
License MIT
Doc PR coming soon

As discussed in symfony-cmf/core-bundle#62 It shoud not be merged until the upstream SonataBlockBundle PR is merged.

@dbu
Copy link
Member

dbu commented Jul 9, 2013

looks good to me. maybe we should just add the renderBlock BC method as sonata can't drop that anyways.

@wouterj
Copy link
Member Author

wouterj commented Jul 12, 2013

@dbu this one is good to merge, isn't it?

@dbu
Copy link
Member

dbu commented Jul 12, 2013

ups. it looks ok, but travis sees a fatal error in the tests: https://travis-ci.org/symfony-cmf/BlockBundle/jobs/8838166 can you check that please? otherwise yes, lets merge and then do the same fix as on the other twig helpers (to not extend the template helper but inject it)

@wouterj
Copy link
Member Author

wouterj commented Jul 14, 2013

I've bumped the version for the composer. Once that version is released, this can be merged.

@rande could you please tag a 2.2.4 release of the SonataBlockBundle, including the renderBlock -> render change?

@dbu
Copy link
Member

dbu commented Jul 15, 2013

@rande: any chance you could tag SonataBlockBundle today? then we could do a tag of this bundle with the cleanup today, that would be neat.

@lsmith77
Copy link
Member

actually .. don't we also need a new SonataAdminBundle for some changes that were merged there .. or am I confused?

@rande
Copy link

rande commented Jul 15, 2013

I just create the tag for the BlockBundle

@dbu dbu closed this Jul 15, 2013
@dbu dbu reopened this Jul 15, 2013
@dbu
Copy link
Member

dbu commented Jul 15, 2013

sorry thomas, should have checked if you created the tag before asking.

dbu added a commit that referenced this pull request Jul 15, 2013
@dbu dbu merged commit 0285c71 into symfony-cmf:master Jul 15, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants