-
Notifications
You must be signed in to change notification settings - Fork 51
Conversation
looks good to me. maybe we should just add the renderBlock BC method as sonata can't drop that anyways. |
@dbu this one is good to merge, isn't it? |
ups. it looks ok, but travis sees a fatal error in the tests: https://travis-ci.org/symfony-cmf/BlockBundle/jobs/8838166 can you check that please? otherwise yes, lets merge and then do the same fix as on the other twig helpers (to not extend the template helper but inject it) |
I've bumped the version for the composer. Once that version is released, this can be merged. @rande could you please tag a 2.2.4 release of the SonataBlockBundle, including the renderBlock -> render change? |
@rande: any chance you could tag SonataBlockBundle today? then we could do a tag of this bundle with the cleanup today, that would be neat. |
actually .. don't we also need a new SonataAdminBundle for some changes that were merged there .. or am I confused? |
I just create the tag for the BlockBundle |
sorry thomas, should have checked if you created the tag before asking. |
As discussed in symfony-cmf/core-bundle#62 It shoud not be merged until the upstream SonataBlockBundle PR is merged.