Added more formats (mostly templating) #179
Conversation
| $container->loadFromExtension('cmf_block', array( | ||
| // ... | ||
| 'caches' => array( | ||
| 'ssi' => array( |
There was a problem hiding this comment.
I can't find this one in the configuration tree of the cmf block bundle. Only varnish and esi are available, are you sure this still works?
There was a problem hiding this comment.
| $container->loadFromExtension('cmf_block', array( | ||
| // ... | ||
| 'caches' => array( | ||
| 'esi' => array( |
There was a problem hiding this comment.
esi = varnish, it is updated some time ago in the SonataCacheBundle and synced to the CmfBlockBundle. We should also update it in the docs. In this PR #180 the yaml part is updated. However you could also update it in this PR and then I update the other PRs accordingly if you want to merge them afterwards?
There was a problem hiding this comment.
I've updated all formats with varnish.
|
this now needs a rebase on master. is it otherwise good to merge? |
|
Only symfony-cmf/block-bundle#82 needs to be merged and I'd like to see how we could fix this example: #179 (comment) (but that can be done after merging) |
|
@dbu rebased |
|
i will merge here, guess blockbundle is fixed very soon. for the twig function, can you please create an issue on the docs repository so we don't forget about this? |
Added more formats (mostly templating)
| extra_cache_keys: { 'extra_key': 'my_block' } | ||
| }) }} | ||
|
|
||
| .. code-block:: php+html |
As promissed, I've updated the core and block bundle docs to reflect the templating changes I made.
I recommend to wait merging this until these PRs are merged: