[WIP] Block: cache - add config to enable esi

[rmsint]

Documentation added for symfony-cmf/block-bundle#84 to enable esi in Symfony configuration.

Changes will be updated after #179 is merged.

[wouterj]

Could you please also add xml and php config?

[rmsint]

@wouterj this config is currently broken: http://symfony.com/doc/master/cmf/bundles/block/cache.html#installation

I am not sure if this will fix it. Do you know what the notation should be for putting a config block in a list?

[wouterj]

The ones you changed are wrong, from the ReSt reference:

List item bodies must be left-aligned and indented relative to the bullet; the text immediately after the bullet determines the indentation.

The problems are the XML and PHP formats, those are indented with 8 spaces intead of the expected 7 spaces. If you change them here and in the block on line 45, it'll work.

[rmsint]

I tried to add the xml config, however I cannot figure out some parts. Maybe you have a tip for me where I can learn about it? I checked the http://symfony.com/doc/current/reference/index.html, however it only contains some snippets.

[wouterj]

Sorry, you must have misunderstood me. I meaned only the XML and PHP for the changes you made, the others are added in #179

[rmsint]

ok, then I will wait untill #179 is merged and add the changes then.

[wouterj]

This should not have been merged, I now get a lot of conflicts...

[lsmith77]

oops .. sorry .. didnt read the text closely enough :(
what should we do now? remove the commits? revert the change?

[wouterj]

Never remove commits in a public repo :)

We could revert 9795d68 and I'll update #179 to include the important changes from that commit. Then, we can say this PR is merged (because 53de460 contains the important stuff).

[lsmith77]

can you open PRs for this? I am struggling to at least get new tags out today for jackalope

[wouterj]

I'll do later this afternoon (I can also push the revert commit immediately without a PR if that helps you)

[rmsint]

oops, if the code is reverted, the change that we should have as result is:

# app/config/config.yml
framework:
    # ...
    esi:             { enabled: true }
    fragments:       { path: /_fragment } # enable FragmentListener to automatically validate and secure fragments
    trusted_proxies: [192.0.0.1, 10.0.0.0/8] # add varnish server ip-address(es)

I forgot to mention the fragments and trusted_proxies in 53de460 and added them in the other commit.