Skip to content

Commit 43f56b7

Browse files
committed
feature #589 [AI Bundle] Use stringNode() and integerNode() for string configuration values (OskarStark)
This PR was squashed before being merged into the main branch. Discussion ---------- [AI Bundle] Use `stringNode()` and `integerNode()` for string configuration values | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | no | Issues | -- | License | MIT Replace `scalarNode()` with more specific node types for better configuration type validation: - Use `stringNode()` for string values (API keys, URLs, service names, etc.) - Use `integerNode()` for integer values (dimensions, etc.) - Keep `scalarNode()` only for mixed-type fields where appropriate This provides better type validation and makes the configuration more self-documenting. ## Changes Made - **String fields**: API keys, URLs, endpoints, service names, class names, database/collection names, etc. now use `stringNode()` - **Integer fields**: `dimensions` and `top_k` fields now use `integerNode()` - **Mixed fields**: Strategy, metric, and similar fields remain as `scalarNode()` ## Needs - [ ] #277 Commits ------- 492f75f [AI Bundle] Use `stringNode()` and `integerNode()` for string configuration values
2 parents 264b4e3 + 492f75f commit 43f56b7

File tree

1 file changed

+137
-127
lines changed

1 file changed

+137
-127
lines changed

0 commit comments

Comments
 (0)