Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use phpunit 7.5 #1000

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@dmaicher
Copy link
Contributor

commented Jun 11, 2019

See #992

And I also updated to phpunit 7.5

@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Thanks a lot David! Also, congrats on creating the 1,000th PR of this repository 🎉

@javiereguiluz javiereguiluz merged commit ab0b711 into symfony:master Jun 11, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

javiereguiluz added a commit that referenced this pull request Jun 11, 2019

bug #1000 use phpunit 7.5 (dmaicher)
This PR was merged into the master branch.

Discussion
----------

use phpunit 7.5

See #992

And I also updated to phpunit 7.5

Commits
-------

ab0b711 use phpunit 7.5

@dmaicher dmaicher deleted the dmaicher:update-phpunit branch Jun 11, 2019

@Kocal

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

Btw, I really think we should removes those lines too.
We will face the same problem whenever we will use SYMFONY_PHPUNIT_REMOVE or SYMFONY_PHPUNIT_DIR

@dmaicher

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

@Kocal feel free to open a PR for it 👍

@Kocal

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

Yep 👍

Also, does someone know why do we need to commit the bin/phpunit file?
We had some discussion with @tristanbes and we could not decide who is right or not... 😄

@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

@Kocal about committing files ... keep in mind that this application is very special. We want everything to work without doing anything or running any command. That's why we do things (e.g. commit the built assets) that you shouldn't do in real apps.

@Kocal

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

We want everything to work without doing anything or running any command

Hum, but how can it works since vendor folder is not committed? 😕

It requires a composer install, and running this command will copy binary files in the bin directory and so we don't need to commit it, right?

@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

@Kocal I meant you don't have to do anything ... when installing it via create-project or the symfony binary. We don't care about people cloning the repo because they know what to do.

Kocal added a commit to Kocal/demo that referenced this pull request Jun 11, 2019

chore(phpunit): remove lines for `SYMFONY_PHPUNIT_REMOVE`
It's a following of symfony#1000.

The `phpunit` binary looks [like this](https://github.com/symfony/recipes/blob/master/symfony/phpunit-bridge/4.3/bin/phpunit) for Symfony 4.3, we don't need `SYMFONY_PHPUNIT_REMOVE` lines.

I also think we don't need `SYMFONY_PHPUNIT_DIR` lines but I'm not really sure.

javiereguiluz added a commit that referenced this pull request Jun 25, 2019

minor #1002 chore(phpunit): remove lines for `SYMFONY_PHPUNIT_REMOVE`…
… (Kocal)

This PR was merged into the master branch.

Discussion
----------

chore(phpunit): remove lines for `SYMFONY_PHPUNIT_REMOVE`

It's a following of #1000.

The `phpunit` binary looks [like this](https://github.com/symfony/recipes/blob/master/symfony/phpunit-bridge/4.3/bin/phpunit) for Symfony 4.3, we don't need `SYMFONY_PHPUNIT_REMOVE` lines too.

I also think we don't need `SYMFONY_PHPUNIT_DIR` lines but I'm not really sure (it's working fine without those lines in one of our app).

Commits
-------

9d7ea6c chore(phpunit): remove lines for `SYMFONY_PHPUNIT_REMOVE`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.