use phpunit 7.5

[dmaicher]

See #992

And I also updated to phpunit 7.5

[javiereguiluz]

Thanks a lot David! Also, congrats on creating the 1,000th PR of this repository 🎉

[Kocal]

Btw, I really think we should removes those lines too.
We will face the same problem whenever we will use SYMFONY_PHPUNIT_REMOVE or SYMFONY_PHPUNIT_DIR

[dmaicher]

@Kocal feel free to open a PR for it 👍

[Kocal]

Yep 👍

Also, does someone know why do we need to commit the bin/phpunit file?
We had some discussion with @tristanbes and we could not decide who is right or not... 😄

[javiereguiluz]

@Kocal about committing files ... keep in mind that this application is very special. We want everything to work without doing anything or running any command. That's why we do things (e.g. commit the built assets) that you shouldn't do in real apps.

[Kocal]

We want everything to work without doing anything or running any command

Hum, but how can it works since vendor folder is not committed? 😕

It requires a composer install, and running this command will copy binary files in the bin directory and so we don't need to commit it, right?

[javiereguiluz]

@Kocal I meant you don't have to do anything ... when installing it via create-project or the symfony binary. We don't care about people cloning the repo because they know what to do.