Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(phpunit): remove lines for `SYMFONY_PHPUNIT_REMOVE` #1002

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Kocal
Copy link

commented Jun 11, 2019

It's a following of #1000.

The phpunit binary looks like this for Symfony 4.3, we don't need SYMFONY_PHPUNIT_REMOVE lines too.

I also think we don't need SYMFONY_PHPUNIT_DIR lines but I'm not really sure (it's working fine without those lines in one of our app).

chore(phpunit): remove lines for `SYMFONY_PHPUNIT_REMOVE`
It's a following of #1000.

The `phpunit` binary looks [like this](https://github.com/symfony/recipes/blob/master/symfony/phpunit-bridge/4.3/bin/phpunit) for Symfony 4.3, we don't need `SYMFONY_PHPUNIT_REMOVE` lines.

I also think we don't need `SYMFONY_PHPUNIT_DIR` lines but I'm not really sure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.