chore(phpunit): remove lines for SYMFONY_PHPUNIT_REMOVE
#1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a following of symfony#1000. The `phpunit` binary looks [like this](https://github.com/symfony/recipes/blob/master/symfony/phpunit-bridge/4.3/bin/phpunit) for Symfony 4.3, we don't need `SYMFONY_PHPUNIT_REMOVE` lines. I also think we don't need `SYMFONY_PHPUNIT_DIR` lines but I'm not really sure.
dmaicher
approved these changes
Jun 12, 2019
|
Thanks Hugo. |
javiereguiluz
added a commit
that referenced
this pull request
Jun 25, 2019
… (Kocal) This PR was merged into the master branch. Discussion ---------- chore(phpunit): remove lines for `SYMFONY_PHPUNIT_REMOVE` It's a following of #1000. The `phpunit` binary looks [like this](https://github.com/symfony/recipes/blob/master/symfony/phpunit-bridge/4.3/bin/phpunit) for Symfony 4.3, we don't need `SYMFONY_PHPUNIT_REMOVE` lines too. I also think we don't need `SYMFONY_PHPUNIT_DIR` lines but I'm not really sure (it's working fine without those lines in one of our app). Commits ------- 9d7ea6c chore(phpunit): remove lines for `SYMFONY_PHPUNIT_REMOVE`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a following of #1000.
The
phpunitbinary looks like this for Symfony 4.3, we don't needSYMFONY_PHPUNIT_REMOVElines too.I also think we don't need
SYMFONY_PHPUNIT_DIRlines but I'm not really sure (it's working fine without those lines in one of our app).