Support code 300 (again) in isRedirect() or explain why not. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 300 code to array of valid redirections in isRedirect(). This remains consistent with deprecated isRedirection() which checked >= 300.
Added 300 code as valid in isRedirect()
|
One reason to not support 300 would be that it is a bit of a different beast -- it's an "Agent Driven" redirect where, instead of a single destination like other 30x codes, in 300 you are supposed to return a menu of possible options (like 3 sizes of videos) and let the User Agent choose which destination to go to. |
|
Thanks for this PR. Yet I invite you to submit it on the main symfony/symfony repository: this is where merges happen. Note that you should add test cases while doing so. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 300 code to array of valid redirections in isRedirect().
This remains consistent with deprecated isRedirection() which checked >= 300.
Not supporting 300 has effects on downstream projects
drupal/redirect : https://www.drupal.org/node/2920454
If there is a good reason for removing support for 300, perhaps it would be a good time to document that.
Thanks!