Make channel selection work with autowired arguments #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While discussing with @nicolas-grekas, we realized that the whole logic we have to handle the |
This only works on Symfony 3.4+, not on Symfony 3.3, but 3.3 is EOL already so this is fine.
stof
added a commit
that referenced
this pull request
Mar 5, 2018
This PR was merged into the 3.x-dev branch. Discussion ---------- Make channel selection work with autowired arguments This only works on Symfony 3.4+, not on Symfony 3.3, but 3.3 is EOL already so this is fine. Closes #218 Closes #228 Replaces #251 Commits ------- 457032a Make channel selection work with autowired arguments
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
May 17, 2018
…rekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Allow defining bindings on ChildDefinition | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Spotted by @stof while trying to put symfony/monolog-bundle#254 into practice. Binding log channels doesn't work because we put this artificial restriction in place. Let's allow ChildDefinition to have bindings (but only at the DI extension level, loaders still forbid defining them at their level because of the parent vs _defaults ambiguity.) Commits ------- 1c3b105 [DI] Allow defining bindings on ChildDefinition
symfony-splitter
pushed a commit
to symfony/dependency-injection
that referenced
this pull request
May 17, 2018
…rekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Allow defining bindings on ChildDefinition | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Spotted by @stof while trying to put symfony/monolog-bundle#254 into practice. Binding log channels doesn't work because we put this artificial restriction in place. Let's allow ChildDefinition to have bindings (but only at the DI extension level, loaders still forbid defining them at their level because of the parent vs _defaults ambiguity.) Commits ------- 1c3b1055df [DI] Allow defining bindings on ChildDefinition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only works on Symfony 3.4+, not on Symfony 3.3, but 3.3 is EOL already so this is fine.
Closes #218
Closes #228
Replaces #251