Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoconfigure resettable processors with the kernel.reset tag #368

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Autoconfigure resettable processors with the kernel.reset tag #368

merged 1 commit into from
Oct 27, 2020

Conversation

alexandre-abrioux
Copy link
Contributor

@alexandre-abrioux alexandre-abrioux commented Oct 11, 2020 •
edited by lyrixx

fixed #361 for more details.

TODO

  • add the kernel.reset tag to processors implementing the ResettableInterface
  • add a test in the MonologExtensionTest class

@alexandre-abrioux alexandre-abrioux mentioned this pull request Oct 11, 2020
Closed
lyrixx
lyrixx approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Could you add a note in the changelog?

Thanks

@alexandre-abrioux
Copy link
Contributor Author

Thanks for the review, changelog updated!

@lyrixx lyrixx changed the title closes #361 - Autoconfigure resettable processors with the kernel.reset tag Autoconfigure resettable processors with the kernel.reset tag Oct 12, 2020
@lyrixx
Copy link
Member

lyrixx commented Oct 27, 2020

Thank you @alexandre-abrioux.

@lyrixx lyrixx merged commit 747b86b into symfony:master Oct 27, 2020
@alexandre-abrioux alexandre-abrioux deleted the iss-361 branch October 27, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@dbrumann dbrumann dbrumann approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autoconfigure resettable processors with the kernel.reset tag
4 participants
@alexandre-abrioux @lyrixx @dbrumann @maxhelias