-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper provides rules for mbstring and iconv polyfills #54
Conversation
note that I used |
@nicolas-grekas the test failure here does not look related to my change |
I believe a package promising to provide some functionality, should really provide all expected functionality. The mbstring polyfill for example does not provide an expected level of compatibility in my opinion, given only UTF-8 is supported. |
@gerryvdm , native mbstring could provide different encodings, you should always check it via |
I'm closing here as nothing changed on Composer's side in more than one year. Let's reopen when it'll be possible. |
With the recent release of Composer 2.0, this is now possible! See also composer/composer#5030 (comment). |
That's a good news, but we'll probably wait a bit for it to be adopted over Composer 1 to avoid issues. |
Once composer/composer#5030 is resolved, this will allow to install
symfony/polyfill-mbstring
in a project and having it fulfill a ext-mbstring requirement set by another library not aware of the polyfill.Without the bug fix, things work already when installing the polyfill from a VCS repo rather than from Packagist or when the polyfill was already installed locally (the bug is on Packagist side when loading metadata).
This would avoid having to do things like beberlei/assert#149 which forces any project using the library to install the polyfill even if they expect to always run with ext-mbstring available (the library could just continue to require ext-mbstring and projects may then choose to require the polyfill to fulfill the dependency)