Fix tests for php 5.5.35/5.6.21/7.0.6 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also https://3v4l.org/Svk6W |
|
We should keep a test covering negative indexes, to ensure they produce the same behavior than PHP for each version (being accepted silently as 0, being rejected, or being taken from the end in PHP 7.1) |
|
@stof fixed |
| @@ -177,7 +177,11 @@ private static function grapheme_position($s, $needle, $offset, $mode) | |||
| if ($offset > 0) { | |||
| $s = self::grapheme_substr($s, $offset); | |||
| } elseif ($offset < 0) { | |||
| $offset = 0; | |||
| if (PHP_VERSION_ID < 50535 || PHP_VERSION_ID < 50621 || PHP_VERSION_ID < 70006) { | |||
There was a problem hiding this comment.
this is wrong, as it will also match PHP 5.6.22 (as 50622 is smaller than 70006). It should be this:
if (PHP_VERSION_ID < 50535 || (PHP_VERSION_ID >= 50600 && PHP_VERSION_ID < 50621) || (PHP_VERSION_ID >= 70000 && PHP_VERSION_ID < 70006)) {
$offset = 0;
} else {
return false;
}There was a problem hiding this comment.
Pff indeed, fixed
|
👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
May 18, 2016
This PR was merged into the 1.1-dev branch. Discussion ---------- Fix tests for php 5.5.35/5.6.21/7.0.6 See tchwork/utf8#59 Commits ------- 99a2aeb Fix tests for php 5.5.35/5.6.21/7.0.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tchwork/utf8#59