On Windows platform STDERR uses temp file too. Fixes blocking of processing. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to php bug 51800, https://bugs.php.net/bug.php?id=51800, output from process must not use pipes. STDIN, STDOUT and STDERR must be redirected to file.
hakre
added a commit
to hakre/Process
that referenced
this pull request
Mar 14, 2013
- As long as PHP does not populate $_ENV it can not be inherited. - A working directory that does not exist does not work. - Descriptors formatting. - stream_set_blocking() takes integer not boolean as second parameter. - Streams on Windows that didn't set to non-blocking should only fread() when there are bytes to read and only fclosed() while being eof. Fixes PHP Bug #51800. See Issue symfony#3.
hakre
added a commit
to hakre/Process
that referenced
this pull request
Mar 14, 2013
…nel (2.0 Backport) - A working directory that does not exist does not work. - Descriptors formatting. - stream_set_blocking() takes integer not boolean as second parameter. - Streams on Windows that didn't set to non-blocking should only fread() when there are bytes to read and only fclosed() while being eof. Fixes PHP Bug #51800. See Issue symfony#3.
|
@jasir: I ran into the same problem and I have found a way on how to do it with blocked pipes under windows. The change is here: hakre@480d4b6#L0R332 - it works by only reading from the blocking streams the bytes that are available (and only if). Same for fclose, only if the stream is eof, then fclose will be called (and not feof()). |
|
Can you close this PR and open a new one on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to php bug 51800, https://bugs.php.net/bug.php?id=51800, output from
process must not use pipes. Both STDOUT and STDERR must be redirected
to file.