Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Leapt FroalaEditor bundle #1302

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

jmsche
Copy link
Contributor

@jmsche jmsche commented Nov 9, 2021

@github-actions
Copy link

github-actions bot commented Nov 9, 2021

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On *nix and Mac
    export SYMFONY_ENDPOINT=https://api.github.com/repos/symfony/recipes-contrib/contents/index.json?ref=flex/pull-1302
    # On Windows
    SET SYMFONY_ENDPOINT=https://api.github.com/repos/symfony/recipes-contrib/contents/index.json?ref=flex/pull-1302
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'leapt/froala-editor-bundle:^1.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On *nix and Mac
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@jmsche
Copy link
Contributor Author

jmsche commented Nov 9, 2021

Hi there,

The CI fail is normal as the bundle requires Symfony 5.3+, so the Symfony 4 check can't succeed.

@jmsche
Copy link
Contributor Author

jmsche commented Jan 25, 2022

Hi, can someone please merge this PR?

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you

@Nyholm Nyholm merged commit 31ec9c7 into symfony:master Feb 19, 2022
OskarStark pushed a commit to OskarStark/recipes-contrib that referenced this pull request Apr 22, 2022
@jmsche jmsche deleted the leapt-froala-editor-bundle branch May 17, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants