Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[symfony/framework-bundle] Add config/preload.php #825

Merged
1 commit merged into from
Sep 30, 2020
Merged

[symfony/framework-bundle] Add config/preload.php #825

1 commit merged into from
Sep 30, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
License MIT
Doc issue/PR -

Follows symfony/symfony#38334

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution, I like it this way!

fabpot added a commit to symfony/symfony that referenced this pull request Sep 30, 2020
…in src/ to make opcache.preload predictable" (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

Revert "bug #38063 [FrameworkBundle] generate preload.php in src/ to make opcache.preload predictable"

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38334
| License       | MIT
| Doc PR        | -

As discussed in the linked issue, let's replace this with a recipe:
symfony/recipes#825

TL;DR, these PRs replace `src/.preload.php` (generated) by `config/preload.php` (committed).

Commits
-------

662fcff Revert "bug #38063 [FrameworkBundle] generate preload.php in src/ to make opcache.preload predictable (nicolas-grekas)"
@ghost ghost merged commit 66b5913 into symfony:master Sep 30, 2020
Guite referenced this pull request in zikula/core Sep 30, 2020
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Oct 1, 2020
This PR was submitted for the master branch but it was merged into the 4.4 branch instead.

Discussion
----------

Update location of preloading file

Follows symfony/symfony#38343 and  symfony/recipes#825

Commits
-------

8213d9c Update location of preloading file
@GPHemsley
Copy link

GPHemsley commented Oct 5, 2020

It appears that the auto-generated src/.preload.php used the current environment (e.g. dev) to create the path of the files, while this recipe hardcodes prod. (It also seems to add a second path.) Is that intentional? Is this something app developers should be configuring?

@nicolas-grekas nicolas-grekas deleted the preload branch October 5, 2020 15:10
@nicolas-grekas
Copy link
Member Author

Is this something app developers should be configuring?

yes, absolutely: like everything in config/, this is yours to tune.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants