-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[symfony/framework-bundle] Add config/preload.php #825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution, I like it this way!
…in src/ to make opcache.preload predictable" (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- Revert "bug #38063 [FrameworkBundle] generate preload.php in src/ to make opcache.preload predictable" | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #38334 | License | MIT | Doc PR | - As discussed in the linked issue, let's replace this with a recipe: symfony/recipes#825 TL;DR, these PRs replace `src/.preload.php` (generated) by `config/preload.php` (committed). Commits ------- 662fcff Revert "bug #38063 [FrameworkBundle] generate preload.php in src/ to make opcache.preload predictable (nicolas-grekas)"
This PR was submitted for the master branch but it was merged into the 4.4 branch instead. Discussion ---------- Update location of preloading file Follows symfony/symfony#38343 and symfony/recipes#825 Commits ------- 8213d9c Update location of preloading file
It appears that the auto-generated |
yes, absolutely: like everything in |
Follows symfony/symfony#38334