This repository was archived by the owner on May 31, 2024. It is now read-only.
Made $map protected and moved it to __construct() #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By making $map protected and moving the actual declaration to the __construct, you make it easier to extend the BasicPermissionMap. At the moment, if you want to extend it, you have to copy/paste the entire $map variable into your own class. I feel it makes more sense to call the parent::__construct in your own mapping and add your own mappings to the variable, instead of having to replace it completely.
symfony-splitter
pushed a commit
that referenced
this pull request
Jan 28, 2017
Update HttpBasicLdapFactory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making $map protected and moving the actual declaration to the
__construct, you make it easier to extend the BasicPermissionMap.
At the moment, if you want to extend it, you have to copy/paste the
entire $map variable into your own class. I feel it makes more sense
to call the parent::__construct in your own mapping and add your own
mappings to the variable, instead of having to replace it completely.