Finish application translation #80
Conversation
|
The reorganization of the English translation is now complete. Please review it before I make the needed changes in the rest of translations. Thanks. |
|
@javiereguiluz if this is merged i will do the german translation if you like and if useful |
|
@OskarStark great! That would be awesome. |
|
ok 😄 |
|
I have a question about the names of the translation strings related to the entity validation. I've defined them as follows, but I don't like it: <trans-unit id="entity.comment_blank">
<source>entity.comment_blank</source>
<target>Please don't leave your comment blank!</target>
</trans-unit>
<trans-unit id="entity.comment_short">
<source>entity.comment_short</source>
<target>Comment is too short ({{ limit }} characters minimum)</target>
</trans-unit>
<trans-unit id="entity.comment_long">
<source>entity.comment_long</source>
<target>Comment is too long ({{ limit }} characters maximum)</target>
</trans-unit>
<trans-unit id="entity.comment_invalid">
<source>entity.comment_invalid</source>
<target>The content of this comment is considered spam.</target>
</trans-unit>
<trans-unit id="entity.summary_blank">
<source>entity.summary_blank</source>
<target>Give your post a summary!</target>
</trans-unit>
<trans-unit id="entity.post_short">
<source>entity.post_short</source>
<target>Post content is too short ({{ limit }} characters minimum)</target>
</trans-unit>What do you think of replacing it by the following? <trans-unit id="comment.blank">
<source>comment.blank</source>
<target>Please don't leave your comment blank!</target>
</trans-unit>
<trans-unit id="comment.too_short">
<source>comment.too_short</source>
<target>Comment is too short ({{ limit }} characters minimum)</target>
</trans-unit>
<trans-unit id="comment.too_long">
<source>comment.too_long</source>
<target>Comment is too long ({{ limit }} characters maximum)</target>
</trans-unit>
<trans-unit id="comment.is_spam">
<source>comment.is_spam</source>
<target>The content of this comment is considered spam.</target>
</trans-unit>
<trans-unit id="comment.blank_summary">
<source>comment.blank_summary</source>
<target>Give your post a summary!</target>
</trans-unit>
<trans-unit id="post.too_short">
<source>post.too_short</source>
<target>Post content is too short ({{ limit }} characters minimum)</target>
</trans-unit> |
|
👍 for shorter version! |
|
@javiereguiluz the domain is validators and not messages for constraints. |
|
@b-durand I can't believe I made this mistake :'( This morning I saw that translation wasn't working for validation ... but I didn't realize this issue. Thanks for telling me! It's fixed now. |
|
We should also localize the date format for "commented on". I regret to have choice with only 4 formats instead of format pattern for skeleton 😞 |
|
@b-durand I'm not sure I understand your last comment about date internationalization. |
|
i think @b-durand would say, that in englisch we use |
|
OK, I understand now. Thanks. Let's do that change in a separate PR because it needs to install the Twig extensions and all that. |
|
@b-durand this feature is finally merged. Thanks a lot for working on this! |
This PR was merged into the master branch. Discussion ---------- Finish application translation This fixes #8 thanks to the work made by @b-durand in #78. Commits ------- 4e677a3 Finished French translation e291f99 Moved french validation translators to its own file df556d3 Fixed some translation errors 7c6e0ed Updated the translation strings related to validation 7770358 Finished reorganizing app translation 9c9f176 Reordered some items and removed duplicates b7dd618 Use XLIFF format only and made some tweaks to translation files b8e40c4 Update the French tranlations 85ee456 Translate constraint messages in Yaml file f2c44f5 Replace the English translations by key 35f2784 Fix domain for error messages
|
@OskarStark this feature is finally merged, so you can update the German translation if you have some free time. Thanks! |
| @@ -32,14 +32,16 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
| // for the full reference of options defined by each form field type | |||
| // see http://symfony.com/doc/current/reference/forms/types.html | |||
| $builder | |||
| ->add('title') | |||
| ->add('summary', 'textarea') | |||
| ->add('title', null, ['label' => 'label.title']) | |||
There was a problem hiding this comment.
this is not compatible with php 5.3 (as stated in composer.json). so I'd suggest increasing the php requirement for the demo. we do not need to support 5.3.
There was a problem hiding this comment.
Good catch! I'm going to check of non-PHP 5.3 features and I'm going to setup a .travis.yml file so we can check on any PHP version. Thanks!
There was a problem hiding this comment.
CI with Travis will be a great!
|
i can do for Hebrew |
This fixes #8 thanks to the work made by @b-durand in #78.