Skip to content

Commit

Permalink
Merge pull request #725 from lsmith77/patch_check_list
Browse files Browse the repository at this point in the history
[WIP] Patch check list
  • Loading branch information
weaverryan committed Sep 23, 2011
2 parents 0649201 + 6fd71e0 commit 0892a2c
Showing 1 changed file with 40 additions and 0 deletions.
40 changes: 40 additions & 0 deletions contributing/code/patches.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,46 @@ Submitting a Patch
Patches are the best way to provide a bug fix or to propose enhancements to
Symfony2.

Check List
----------

The purpose of the check list is to ensure that contributions may be reviewed
with needless feedback loops to ensure that your contributions can be included
into Symfony2 as quickly as possible.

.. warning::

All pull requests should include the following template in the request
description:

.. code-block:: plain
Bug fix: [yes|no]
Feature addition: [yes|no]
Backwards compatibility break: [yes|no]
Symfony2 tests pass: [yes|no]
Fixes the following tickets: [comma separated list of tickets fixed by the PR]
An example submission could now look as follows:

.. code-block:: plain
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Thank you for including the filled out template in your submission!

.. tip::

All feature addition's should be send to the "master" branch, while all
bug fixes should be send to the oldest still active branch. Furthermore
submissions should as a rule of thumb not break backwards compatibility.
Please mark any submissions as "[WIP]" in the title in case the submission
is not yet complete (for example if the tests do not yet pass).

Initial Setup
-------------

Expand Down

0 comments on commit 0892a2c

Please sign in to comment.