Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] Add intl/choice_translation_locale options to TimezoneType #11503

Closed
ro0NL opened this issue Apr 29, 2019 · 1 comment
Closed

[Form] Add intl/choice_translation_locale options to TimezoneType #11503

ro0NL opened this issue Apr 29, 2019 · 1 comment
Assignees
@javiereguiluz
Labels
Form hasPR A Pull Request has already been submitted for this issue.
Milestone
4.3

Comments

@ro0NL
Copy link
Contributor

ro0NL commented Apr 29, 2019

see symfony/symfony#31294 (ref #9657)
@ro0NL ro0NL mentioned this issue Apr 29, 2019
Merged
@javiereguiluz javiereguiluz added this to the 4.3 milestone May 7, 2019
@ro0NL
Copy link
Contributor Author

ro0NL commented May 10, 2019

to clarify, TimezoneType can vary between PHP and ICU based on the intl option

TimezoneValidator is a hybrid that accepts inputs from both

fabpot added a commit to symfony/symfony that referenced this issue May 13, 2019
@fabpot
feature #31294 [Form] Add intl/choice_translation_locale option to Ti…
a326acc 
…mezoneType (ro0NL)

This PR was merged into the 4.3 branch.

Discussion
----------

[Form] Add intl/choice_translation_locale option to TimezoneType

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #28836
| License       | MIT
| Doc PR        | symfony/symfony-docs#11503

final step :)

for now i think any form of grouping is a user concern (i.e. by GMT offset or area name); see #31293 + #31295

having a special built in `group_by' => 'gmt_offset'` util would be nice, and can be done in the future.

includes #31434

Commits
-------

001b930 [Form] Add intl/choice_translation_locale option to TimezoneType
@javiereguiluz javiereguiluz self-assigned this Jul 2, 2019
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Jul 2, 2019
@javiereguiluz javiereguiluz mentioned this issue Jul 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javiereguiluz javiereguiluz

Labels
Form hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
4.3
Development

No branches or pull requests
2 participants
@javiereguiluz @ro0NL