Skip to content

Commit

Permalink
minor #11077 [TwigBundle] [Tests] Add framework-bundle (clemens-tolboom)
Browse files Browse the repository at this point in the history
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #11077).

Discussion
----------

[TwigBundle] [Tests] Add framework-bundle

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   |[yes
| Fixed tickets | -
| License       | MIT
| Doc PR        |

I'm unable to run the test from within TwigBundle

```bash
src/Symfony/Bundle/TwigBundle
composer install
phpunit
```
gives
```
PHP Fatal error:  Class 'Symfony\Bundle\FrameworkBundle\Templating\TemplateReference' not found
```

Adding the FrameworkBundle fixes this but is that what is needed?

I believe `require` and `require-dev` should use `dev-master`
- [x] require(-dev) is not up to par with symfony master.

Commits
-------

a12471d Add framework-bundle
  • Loading branch information
fabpot committed Jun 16, 2014
2 parents 92d93ce + a12471d commit 185aafa
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/Symfony/Bundle/TwigBundle/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
"require-dev": {
"symfony/stopwatch": "~2.2",
"symfony/dependency-injection": "~2.0",
"symfony/config": "~2.2"
"symfony/config": "~2.2",
"symfony/framework-bundle": "~2.1"
},
"autoload": {
"psr-0": { "Symfony\\Bundle\\TwigBundle\\": "" }
Expand Down

0 comments on commit 185aafa

Please sign in to comment.